Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras): update transactional email logo default size #3506

Merged

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1208629737155849/f

This PR adjusts the default site logo width in transactional emails to the expected value (here in the newsletters plugin)

How to test the changes in this Pull Request:

  1. As admin, go to Newspack > Engagement > Show Advanced Settings > Transactional Email Content
  2. Reset the Set a New Password template
  3. Edit the template and confirm the logo is 125px wide
  4. Send a test email and confirm the logo is 125px wide in the sent email

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle added [Status] Needs Review The issue or pull request needs to be reviewed ras-acc testing labels Oct 27, 2024
@chickenn00dle chickenn00dle requested a review from a team as a code owner October 27, 2024 18:00
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 28, 2024
@chickenn00dle chickenn00dle merged commit 0614ea0 into epic/ras-acc Oct 29, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/transactional-email-template-colors-and-logo branch October 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ras-acc testing [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants